Re: BUG #6044: Access violation on XML decl with standalone - Mailing list pgsql-bugs

From Tom Lane
Subject Re: BUG #6044: Access violation on XML decl with standalone
Date
Msg-id 9897.1306548255@sss.pgh.pa.us
Whole thread Raw
In response to BUG #6044: Access violation on XML decl with standalone  ("Christopher Dillard" <csdillard@gmail.com>)
List pgsql-bugs
"Christopher Dillard" <csdillard@gmail.com> writes:
> In PostgreSQL 8.4.8, the function "xml_recv" (in
> src/backend/utils/adt/xml.c) calls the function "parse_xml_decl", passing
> NULL for the final "standalone" parameter.  However, "parse_xml_decl" does
> not check for standalone==NULL, and blindly sets "*standalone = 0".  This
> causes a crash if the xml declaration actually has a standalone parmeter,
> e.g. '<?xml version="1.0" standalone="no"?><anything/>'.

Ugh, you're right.

> I wish I could provide a SQL test case, but I only found this by setting a
> breakpoint on the 0xC0000005 exception in Visual Studio.

AFAIK there isn't any way to exercise the receive functions via psql.
You need a client that will send data as binary parameters.  But it's
obvious by inspection of the code that it's broken.  Will fix, thanks
for the report!

            regards, tom lane

pgsql-bugs by date:

Previous
From: Alexey Klyukin
Date:
Subject: Re: 9.1 plperlu bug with null rows in trigger hash
Next
From: Alvaro Herrera
Date:
Subject: Re: 9.1 plperlu bug with null rows in trigger hash