Re: Fix for REFRESH MATERIALIZED VIEW ownership error message - Mailing list pgsql-hackers

From Jonathan S. Katz
Subject Re: Fix for REFRESH MATERIALIZED VIEW ownership error message
Date
Msg-id 987F9F3C-6578-4A06-9E0B-FE73F22B7DE7@postgresql.org
Whole thread Raw
In response to Re: Fix for REFRESH MATERIALIZED VIEW ownership error message  ("David G. Johnston" <david.g.johnston@gmail.com>)
Responses Re: Fix for REFRESH MATERIALIZED VIEW ownership error message
List pgsql-hackers

On Aug 18, 2018, at 5:26 PM, David G. Johnston <david.g.johnston@gmail.com> wrote:

On Saturday, August 18, 2018, Jonathan S. Katz <jkatz@postgresql.org> wrote:
It’s cosmetic, but it’s a cosmetic bug: it incorrectly tells the user that they
must be the owner of the “relational” when in reality it’s the materialized view.

Materialized views are a type of relation so it is not wrong, just one of many instances where we generalize to "relation" based in implementation details ins team of being explicit about which type of relation is being affected.

Sure, that’s technically correct, but it’s still confusing to a user,
particularly in this cased since the error comes from running
"REFRESH MATERIALIZED VIEW" which is only applied to materialized views.

For instance, if you try running the command on a table:

    CREATE TABLE a (x int);
    REFRESH MATERIALIZED VIEW a;
    ERROR:  "a" is not a materialized view

which is what you would and should expect.

Jonathan

Attachment

pgsql-hackers by date:

Previous
From: "David G. Johnston"
Date:
Subject: Re: Fix for REFRESH MATERIALIZED VIEW ownership error message
Next
From: Dave Cramer
Date:
Subject: Re: Fix for REFRESH MATERIALIZED VIEW ownership error message