Re: Streaming Replication on win32 - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: Streaming Replication on win32
Date
Msg-id 9837222c1002150833h94a9888vac84053341e8f861@mail.gmail.com
Whole thread Raw
In response to Re: Streaming Replication on win32  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Streaming Replication on win32
List pgsql-hackers
2010/2/15 Tom Lane <tgl@sss.pgh.pa.us>:
> Magnus Hagander <magnus@hagander.net> writes:
>> I changed your patch to this, because I find it a lot simpler. The
>> change is in the checking in pgwin32_recv - there is no need to ever
>> call waitforsinglesocket, we can just exit out early.
>
>> Do you see any issue with that?
>
> This definitely looks cleaner, but is there a reason not to use bool
> instead of int here?

No.


-- Magnus HaganderMe: http://www.hagander.net/Work: http://www.redpill-linpro.com/


pgsql-hackers by date:

Previous
From: Magnus Hagander
Date:
Subject: RADIUS secret in file
Next
From: Stefan Kaltenbrunner
Date:
Subject: Re: RADIUS secret in file