Re: Streaming Replication on win32 - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: Streaming Replication on win32
Date
Msg-id 3f0b79eb1002151802t34098ed9o609809fd84d3f9a3@mail.gmail.com
Whole thread Raw
In response to Re: Streaming Replication on win32  (Magnus Hagander <magnus@hagander.net>)
Responses Re: Streaming Replication on win32
List pgsql-hackers
On Tue, Feb 16, 2010 at 1:33 AM, Magnus Hagander <magnus@hagander.net> wrote:
> 2010/2/15 Tom Lane <tgl@sss.pgh.pa.us>:
>> Magnus Hagander <magnus@hagander.net> writes:
>>> I changed your patch to this, because I find it a lot simpler. The
>>> change is in the checking in pgwin32_recv - there is no need to ever
>>> call waitforsinglesocket, we can just exit out early.

Thanks a lot, Magnus!

>>> Do you see any issue with that?
>>
>> This definitely looks cleaner, but is there a reason not to use bool
>> instead of int here?
>
> No.

Can include/port/win32.h refer to bool type?

Regards,

-- 
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center


pgsql-hackers by date:

Previous
From: Fujii Masao
Date:
Subject: Re: TCP keepalive support for libpq
Next
From: Robert Haas
Date:
Subject: Re: Explain buffers display units.