Re: Streaming Replication on win32 - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Streaming Replication on win32
Date
Msg-id 284.1266250864@sss.pgh.pa.us
Whole thread Raw
In response to Re: Streaming Replication on win32  (Magnus Hagander <magnus@hagander.net>)
Responses Re: Streaming Replication on win32
List pgsql-hackers
Magnus Hagander <magnus@hagander.net> writes:
> I changed your patch to this, because I find it a lot simpler. The
> change is in the checking in pgwin32_recv - there is no need to ever
> call waitforsinglesocket, we can just exit out early.

> Do you see any issue with that?

This definitely looks cleaner, but is there a reason not to use bool
instead of int here?
        regards, tom lane


pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: TCP keepalive support for libpq
Next
From: Magnus Hagander
Date:
Subject: RADIUS secret in file