Re: [PATCH] Windows x64 [repost] - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: [PATCH] Windows x64 [repost]
Date
Msg-id 9837222c0912301530v7c01f3c7g1b9f9877c1aa4a4d@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Windows x64 [repost]  (Tsutomu Yamada <tsutomu@sraoss.co.jp>)
Responses Re: [PATCH] Windows x64 [repost]  (Magnus Hagander <magnus@hagander.net>)
List pgsql-hackers
2009/12/4 Tsutomu Yamada <tsutomu@sraoss.co.jp>:
> Thanks to suggestion.
> I send pathces again by another mailer for the archive.
>
> Sorry to waste resources, below is same content that I send before.

I have a couple of comments about the first patch (I'll get to the
others later):

config.win32.h has:
+ #ifdef _MSC_VER
+ /* #undef HAVE_STDINT_H */
+ #else #define HAVE_STDINT_H 1
+ #endif

Is that really necessary? config.h.win32 is only used on MSVC builds, no?

A bit further down, it has:

+ /* The size of `void *', as computed by sizeof. */
+ #define SIZEOF_VOID_P 4
+


shouldn't that be 8 for win64 platforms?

This patch also needs autoconf support for other platforms, but I've
bugged Bruce about that and have some code to get that done. Just
wanted these questions settled before I move on.

-- Magnus HaganderMe: http://www.hagander.net/Work: http://www.redpill-linpro.com/


pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Allowing x IS NOT NULL as a btree search condition
Next
From: Andres Freund
Date:
Subject: Re: Hot Standy introduced problem with query cancel behavior