Re: Enable SSPI on cygwin - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: Enable SSPI on cygwin
Date
Msg-id 9837222c0907241455r5f08b713i42d79fa12aa4dd10@mail.gmail.com
Whole thread Raw
In response to Enable SSPI on cygwin  (Reini Urban <rurban@x-ray.at>)
List pgsql-hackers
On Fri, Jul 24, 2009 at 23:47, Reini Urban<rurban@x-ray.at> wrote:
> Attached is my patch to enable SSPI on cygwin.

Is it really such a good idea to keep doing #define WIN32 and #undef
WIN32 in multiple places? It seems very fragile to me - we should keep
the defines for cygwin and win32 separate. Even if that means that the
patch changes a bunch of places into (win32 or cygwin). Either that,
or we need to declare a global define somewhere that is
WIN32_OR_CYGWIN. Doing it this way makes it much harder to spot what
the defines actually mean.

IIRC, we discussed that before, and came to a similar conclusion, but
I could be wrong.


-- Magnus HaganderSelf: http://www.hagander.net/Work: http://www.redpill-linpro.com/


pgsql-hackers by date:

Previous
From: Stephen Frost
Date:
Subject: Re: Proposal: More portable way to support 64bit platforms
Next
From: "David E. Wheeler"
Date:
Subject: Re: When is a record NULL?