Re: new heapcheck contrib module - Mailing list pgsql-hackers

From Mark Dilger
Subject Re: new heapcheck contrib module
Date
Msg-id 98265AA9-7BDC-4708-9348-CC1B173BBE1D@enterprisedb.com
Whole thread Raw
In response to Re: new heapcheck contrib module  (Mark Dilger <mark.dilger@enterprisedb.com>)
Responses Re: new heapcheck contrib module  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers

> On Oct 5, 2020, at 5:24 PM, Mark Dilger <mark.dilger@enterprisedb.com> wrote:
>
> There remain a few open issues and/or things I did not implement:
>
> - This version follows Robert's suggestion of using pg_class_aclcheck() to check that the caller has permission to
selectfrom the table being checked.  This is inconsistent with the btree checking logic, which does no such check.
Thesetwo approaches should be reconciled, but there was apparently no agreement on this issue. 

This next version, attached, has the acl checking and associated documentation changes split out into patch 0005,
makingit easier to review in isolation from the rest of the patch series. 

Independently of acl considerations, this version also has some verbiage changes in 0004, in response to Andrey's
reviewupthread. 





—
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company




Attachment

pgsql-hackers by date:

Previous
From: James Coleman
Date:
Subject: Re: enable_incremental_sort changes query behavior
Next
From: Ajin Cherian
Date:
Subject: Re: [HACKERS] logical decoding of two-phase transactions