Re: behaviour change - default_tablesapce + partition table - Mailing list pgsql-hackers

From Amit Langote
Subject Re: behaviour change - default_tablesapce + partition table
Date
Msg-id 9811f5f3-36d2-39c0-9520-e4c3573d151f@lab.ntt.co.jp
Whole thread Raw
In response to Re: behaviour change - default_tablesapce + partition table  (Rushabh Lathia <rushabh.lathia@gmail.com>)
List pgsql-hackers
On 2019/05/20 13:42, Rushabh Lathia wrote:
> On Fri, May 17, 2019 at 10:30 AM Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
>> Why not change it like this instead:
>>
>> @@ -681,7 +681,8 @@ DefineRelation(CreateStmt *stmt, char relkind, Oid
>> ownerId,
>>          Assert(list_length(inheritOids) == 1);
>>          tablespaceId = get_rel_tablespace(linitial_oid(inheritOids));
>>      }
>> -    else
>> +
>> +    if (!OidIsValid(tablespaceId))
>>          tablespaceId =
>> GetDefaultTablespace(stmt->relation->relpersistence,
>>                                              partitioned);
> 
> Yes, sure we can do that. Here is the patch for the same.

Thanks Rushabh.

Regards,
Amit




pgsql-hackers by date:

Previous
From: Rushabh Lathia
Date:
Subject: Re: behaviour change - default_tablesapce + partition table
Next
From: Akim Demaille
Date:
Subject: Re: Remove useless associativity/precedence from parsers