Re: Add cassert-only checks against unlocked use of relations - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Add cassert-only checks against unlocked use of relations
Date
Msg-id 970.1383689961@sss.pgh.pa.us
Whole thread Raw
In response to Re: Add cassert-only checks against unlocked use of relations  (Andres Freund <andres@2ndquadrant.com>)
Responses Re: Add cassert-only checks against unlocked use of relations  (Andres Freund <andres@2ndquadrant.com>)
List pgsql-hackers
Andres Freund <andres@2ndquadrant.com> writes:
> On that note, any chance you remember why you increased MAX_LOCKMODE by
> 2 to 10 back in 2001 although AccessExclusiveLock is 8? The relevant
> commit is 4fe42dfbc3bafa0ea615239d716a6b37d67da253 .

Probably because it seemed like a round number, which 9 wasn't ...
keep in mind that this data structure is nominally intended to support
other lock semantics besides what LockConflicts[] defines.  (BTW,
it's a conceptual error to imagine that the numerical values of the
lock mode codes define a strict "strength" ordering, which is another
reason I don't care for your patch.)
        regards, tom lane



pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: UTF8 national character data type support WIP patch and list of open issues.
Next
From: Tom Lane
Date:
Subject: Re: Window functions can be created with defaults, but they don't work