Re: [HACKERS] [PATCH] Rename pg_switch_xlog to pg_switch_wal - Mailing list pgsql-hackers

From David Steele
Subject Re: [HACKERS] [PATCH] Rename pg_switch_xlog to pg_switch_wal
Date
Msg-id 96560411-1a28-7caa-2c1f-947e91da5d81@pgmasters.net
Whole thread Raw
In response to Re: [HACKERS] [PATCH] Rename pg_switch_xlog to pg_switch_wal  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: [HACKERS] [PATCH] Rename pg_switch_xlog to pg_switch_wal  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
On 1/27/17 6:47 PM, Michael Paquier wrote:
> On Sat, Jan 28, 2017 at 8:03 AM, Peter Eisentraut
> <peter.eisentraut@2ndquadrant.com> wrote:
>> On 1/26/17 2:05 PM, Robert Haas wrote:
>>> I do not think it can be right to rename the directory and not
>>> anything else.
>>
>> I think this is the root of the confusion.
>>
>> A lot of people apparently consented to renaming pg_xlog with the
>> understanding that that's it, whereas other people understood it as
>> consensus for renaming everything.
>>
>> You really have (at least) three options here:
>>
>> 1. Rename nothing
>> 2. Rename directory only
>> 3. Rename everything
>>
>> and you need to count the votes of each pair separately.
>
> 4. Rename everything with aliases.
>
> I would vote for 4., or 3. for consistency if 4. is not an eligible choice.

I vote for 3.

The problem I have with aliases is that they would need to be done 
across the board.  At the least, we would need function aliases, 
symlinks for the binaries (which would rneed to be done by the 
packagers), aliases for the command line options, and lots of notations 
in the documentation.

All of this would need to be preserved more or less indefinitely, 
because if we can't decide on a break now it's not likely to happen later.

-- 
-David
david@pgmasters.net



pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: [HACKERS] WIP: About CMake v2
Next
From: Craig Ringer
Date:
Subject: Re: [HACKERS] BUG: pg_stat_statements query normalization issues withcombined queries