Re: patch for parallel pg_dump - Mailing list pgsql-hackers

From Tom Lane
Subject Re: patch for parallel pg_dump
Date
Msg-id 9632.1333471063@sss.pgh.pa.us
Whole thread Raw
In response to Re: patch for parallel pg_dump  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: patch for parallel pg_dump
List pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes:
> On Tue, Apr 3, 2012 at 12:17 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> No, the reason for write_stderr() is that fprintf(stderr) is unreliable
>> on Windows. �If memory serves, it can actually crash in some situations.

> Dude, we're already doing fprintf(stderr) all over pg_dump.  If it's
> unreliable even in front-end code, we're screwed anyway.  That is a
> non-objection.

No, it isn't.  The fact that it works in pg_dump doesn't extrapolate
to other places.  (In particular, it will absolutely not work in libpq,
at least not in all the environments where libpq is supposed to work.)

I think what we've got at the moment is something that's adequate for
pg_dump, and that's all that it is.  Concluding that it can be used in
all frontend code is way premature, and therefore I'm -1 on the idea
of exposing it in non-pg_dump header files.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: patch for parallel pg_dump
Next
From: Robert Haas
Date:
Subject: Re: patch for parallel pg_dump