Re: new heapcheck contrib module - Mailing list pgsql-hackers

From Mark Dilger
Subject Re: new heapcheck contrib module
Date
Msg-id 962F7333-B560-4FB9-B5A5-41664EC5F629@enterprisedb.com
Whole thread Raw
In response to Re: new heapcheck contrib module  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers

> On Oct 26, 2020, at 9:12 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> Robert Haas <robertmhaas@gmail.com> writes:
>> On Wed, Oct 21, 2020 at 11:45 PM Mark Dilger
>> <mark.dilger@enterprisedb.com> wrote:
>>> Done that way in the attached, which also include Robert's changes from v19 he posted earlier today.
>
>> Committed. Let's see what the buildfarm thinks.
>
> Another thing that the buildfarm is pointing out is
>
> [WARN] FOUserAgent - The contents of fo:block line 2 exceed the available area in the inline-progression direction by
morethan 50 points. (See position 148863:380) 
>
> This is coming from the sample output for verify_heapam(), which is too
> wide to fit in even a normal-size browser window, let alone A4 PDF.
>
> While we could perhaps hack it up to allow more line breaks, or see
> if \x formatting helps, my own suggestion would be to just nuke the
> sample output altogether.

Ok.

> It doesn't look like it is any sort of
> representative real output,

It is not.  It came from artificially created corruption in the regression tests.  I may even have manually edited
that,though I don't recall. 

> and it is not useful enough to be worth
> spending time to patch up.

Ok.

—
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company






pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: libpq debug log
Next
From: Alvaro Herrera
Date:
Subject: Re: PATCH: Report libpq version and configuration