Re: [PATCH] Query Jumbling for CALL and SET utility statements - Mailing list pgsql-hackers

From Drouvot, Bertrand
Subject Re: [PATCH] Query Jumbling for CALL and SET utility statements
Date
Msg-id 95c702fa-61a1-1bc1-7313-4f2b46fdaf94@amazon.com
Whole thread Raw
In response to Re: [PATCH] Query Jumbling for CALL and SET utility statements  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers

Hi,

On 9/8/22 7:23 AM, Michael Paquier wrote:
On Wed, Sep 07, 2022 at 06:19:42PM -0700, Jeremy Schneider wrote:
I didn't fully debug yet, but here's the backtrace on my 14.4 build with
the patch

Thanks Jeremy for reporting the issue!

What happens on HEAD?  That would be the target branch for a new
feature.

Just tested and i can see the same issue on HEAD.

Issue is on stmt->name being NULL here:

Breakpoint 2, JumbleExpr (jstate=0x55d60e769e30, node=0x55d60e769b60) at queryjumble.c:364
364             if (node == NULL)
(gdb) n
368             check_stack_depth();
(gdb)
374             APP_JUMB(node->type);
(gdb)
376             switch (nodeTag(node))
(gdb)
398                                     VariableSetStmt *stmt = (VariableSetStmt *) node;
(gdb) n
400                                     APP_JUMB_STRING(stmt->name);
(gdb) p stmt->name
$1 = 0x0

I'll have a closer look.

Regards,
--

Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

pgsql-hackers by date:

Previous
From: Pavel Stehule
Date:
Subject: Re: broken table formatting in psql
Next
From: Julien Rouhaud
Date:
Subject: Re: [PATCH] Query Jumbling for CALL and SET utility statements