Re: [PATCH] Fix alter subscription concurrency errors - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] Fix alter subscription concurrency errors
Date
Msg-id 956468.1679335244@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCH] Fix alter subscription concurrency errors  ("Gregory Stark (as CFM)" <stark.cfm@gmail.com>)
Responses Re: [PATCH] Fix alter subscription concurrency errors  (Jelte Fennema <postgres@jeltef.nl>)
List pgsql-hackers
"Gregory Stark (as CFM)" <stark.cfm@gmail.com> writes:
> Hm. This patch is still waiting on updates. But it's a bug fix and it
> would be good to get this in. Is someone else interested in finishing
> this if Jeite isn't available?

I think the patch as-submitted is pretty uninteresting, mainly because the
design of adding bespoke lock code for subscription objects doesn't scale.
I'm not excited about doing this just for subscriptions without at least a
clear plan for working on other object types.

Alvaro suggested switching it to use get_object_address() instead, which'd
be better; but before going in that direction we might have to do more
work on get_object_address's error reporting (note the para in its header
comments saying it's pretty weak on that).

            regards, tom lane



pgsql-hackers by date:

Previous
From: "Gregory Stark (as CFM)"
Date:
Subject: Re: Fix order of checking ICU options in initdb and create database
Next
From: Tom Lane
Date:
Subject: Re: Save a few bytes in pg_attribute