Re: New "raw" COPY format - Mailing list pgsql-hackers

From Joel Jacobson
Subject Re: New "raw" COPY format
Date
Msg-id 95219616-d547-4204-9adf-bc5586a1053c@app.fastmail.com
Whole thread Raw
In response to Re: New "raw" COPY format  (Tatsuo Ishii <ishii@postgresql.org>)
List pgsql-hackers
On Mon, Oct 21, 2024, at 16:35, jian he wrote:
> make the ProcessCopyOptions process in following order:
> 1. Extract options from the statement node tree
> 2. checking each option, if not there set default value.
> 3. checking for interdependent options
>
> I still think
> making step2 aligned with the doc parameter section order will make it
> more readable.
>
> based on your patch
> (v12-0001-Refactor-ProcessCopyOptions-introduce-CopyFormat-enu.patch)
> I put some checking to step3, make step2 checking order aligned with doc.

Smart to move the interdependent check to the designated section for it,
that's exactly the right place for it.

Really nice the order in the code now is aligned with the doc order.

/Joel



pgsql-hackers by date:

Previous
From: "Joel Jacobson"
Date:
Subject: Re: [PATCH] Add array_reverse() function
Next
From: Tom Lane
Date:
Subject: Re: [PATCH] Add array_reverse() function