Re: Command Triggers, patch v11 - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Command Triggers, patch v11
Date
Msg-id 9503.1332006327@sss.pgh.pa.us
Whole thread Raw
In response to Re: Command Triggers, patch v11  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Command Triggers, patch v11  (Andres Freund <andres@anarazel.de>)
Re: Command Triggers, patch v11  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
While looking at this I also noticed that DECLARE CURSOR uses a
structure that's randomly different in yet a third way: we start
with a utility statement containing a query, and then flip that
upside down so that the SELECT Query contains a utility statement!

I have a vague feeling that I'm the one who's guilty of that hack, too.

I'm not sure that anybody cares about being able to fire command
triggers on DECLARE CURSOR, but just from a consistency standpoint it
would make sense for this to work more like EXPLAIN and CREATE TABLE AS.
So that convinces me that UtilityContainsQuery() would be a good thing,
and I'll add that to the patch.  (Actually changing DECLARE CURSOR seems
like a separate patch, though.)
        regards, tom lane


pgsql-hackers by date:

Previous
From: "Atri Sharma"
Date:
Subject: Re: Regarding column reordering project for GSoc 2012
Next
From: Greg Stark
Date:
Subject: Re: Memory usage during sorting