Re: Improve XLOG_NO_TRAN related comments - Mailing list pgsql-patches

From Tom Lane
Subject Re: Improve XLOG_NO_TRAN related comments
Date
Msg-id 9457.1135609744@sss.pgh.pa.us
Whole thread Raw
In response to Re: Improve XLOG_NO_TRAN related comments  (Qingqing Zhou <zhouqq@cs.toronto.edu>)
List pgsql-patches
Qingqing Zhou <zhouqq@cs.toronto.edu> writes:
> On Sat, 24 Dec 2005, Tom Lane wrote:
>> Removing these comments entirely, without changing the code they explain,
>> doesn't strike me as an improvement.

> I just checked if we can remove XLOG_NO_TRAN happily, and the conclusion
> is that it could bring some benefits (though not much) to our system. The
> key is the CheckpointStartLock lock.

Hm.  Perhaps we could keep the current behavior and re-document
XLOG_NO_TRAN as meaning that the xlog record does not involve the
insertion of our XID into permanent storage.

            regards, tom lane

pgsql-patches by date:

Previous
From: Qingqing Zhou
Date:
Subject: Re: Improve XLOG_NO_TRAN related comments
Next
From: Karel Zak
Date:
Subject: Re: [HACKERS] to_char and i18n