Postgres Pro
Downloads
Home   >   mailing lists

Re: pgsql: This patch fixes this warning. - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: This patch fixes this warning.
Date
Msg-id 9456.1141432057@sss.pgh.pa.us
Whole thread Raw
In response to pgsql: This patch fixes this warning.  (momjian@postgresql.org (Bruce Momjian))
List pgsql-committers
Tree view 
momjian@postgresql.org (Bruce Momjian) writes:
> Log Message:
> -----------
> This patch fixes this warning.

> gettimeofday.c:35: warning: integer constant is too large for "long"
> type

Wouldn't it be better to use the UINT64CONST macro?  I realize this
file is Windows-only, but we do worry about more than one compiler
on that platform.

            regards, tom lane

pgsql-committers by date:

Previous
From: momjian@postgresql.org (Bruce Momjian)
Date:
Subject: pgsql: This patch fixes this warning.
Next
From: momjian@postgresql.org (Bruce Momjian)
Date:
Subject: pgsql: That was a typo in my comment before the code (the nutshell