Re: extensible options syntax for replication parser? - Mailing list pgsql-hackers

From tushar
Subject Re: extensible options syntax for replication parser?
Date
Msg-id 9400af96-f834-74f9-2d5d-5f5f751fb6a5@enterprisedb.com
Whole thread Raw
In response to Re: extensible options syntax for replication parser?  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: extensible options syntax for replication parser?
Re: extensible options syntax for replication parser?
Re: extensible options syntax for replication parser?
List pgsql-hackers
On 9/24/21 10:36 PM, Robert Haas wrote:
> Here's v9, fixing the issue reported by Fujii Masao.

Please refer this scenario where publication on v14RC1  and subscription 
on HEAD (w/patch)

--create a subscription with parameter two_phase=1 on HEAD

postgres=# CREATE SUBSCRIPTION r1015 CONNECTION 'dbname=postgres 
host=localhost port=5454' PUBLICATION p WITH (two_phase=1);
NOTICE:  created replication slot "r1015" on publisher
CREATE SUBSCRIPTION
postgres=#

--check on 14RC1

postgres=# select two_phase from pg_replication_slots where 
slot_name='r105';
  two_phase
-----------
  f
(1 row)

so are we silently ignoring this parameter as it is not supported on 
v14RC/HEAD ? and if yes then why not we just throw an message like
ERROR:  unrecognized subscription parameter: "two_phase"

-- 
regards,tushar
EnterpriseDB  https://www.enterprisedb.com/
The Enterprise PostgreSQL Company




pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: standby recovery fails (tablespace related) (tentative patch and discussion)
Next
From: tushar
Date:
Subject: Re: extensible options syntax for replication parser?