Re: BUG #7792: pg_dump does not treat -c flag correctly when using tar format - Mailing list pgsql-bugs

From Eli Mesika
Subject Re: BUG #7792: pg_dump does not treat -c flag correctly when using tar format
Date
Msg-id 938821469.1644658.1357549703303.JavaMail.root@redhat.com
Whole thread Raw
In response to Re: BUG #7792: pg_dump does not treat -c flag correctly when using tar format  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-bugs
----- Original Message -----
> From: "Tom Lane" <tgl@sss.pgh.pa.us>
> To: emesika@redhat.com
> Cc: pgsql-bugs@postgresql.org
> Sent: Monday, January 7, 2013 2:32:06 AM
> Subject: Re: [BUGS] BUG #7792: pg_dump does not treat -c flag correctly when using tar format
>
> emesika@redhat.com writes:
> > 1) pg_dump -F t -U postgres -f test.tar test
> > 2) tar xvf test.tar  to any directory
> > 3) vi restore.sql
> > * restore.sql includes DROP statements for each object even tough
> > -c flag
> > was not given
>
> I believe this is intentional - at least, pg_backup_tar.c goes out of
> its way to make it happen.  (The forcible setting of ropt->dropSchema
> in _CloseArchive is the cause, and it's hard to see why that would be
> there unless the author intended this effect.)  Perhaps we should
> remove
> that, but it would be an incompatible change.  Arguing for or against
> it really requires a model of what people would be doing with the
> restore.sql script.  I'm not entirely convinced that it should be
> considered equivalent to what you'd get from a plain dump run.

Tom, thanks for the quick respond.
I find that very confusing:
Currently, in order to use the pg_restore (tar format), you will have to create first the database with the same schema
youare going to restore while the most convenient usage is to create a new empty database and run the restore.  
Also, that contradict with the pg_dump -C flag that adds database creation statement and it is clear that DROP
statementswill fail on a clean database. 

Regards
Eli



>
>             regards, tom lane
>

pgsql-bugs by date:

Previous
From: Aleksander Shniperson
Date:
Subject: Re: BUG #7781: pgagent incorrect installation
Next
From: paul.watson@zephyr-consulting.com
Date:
Subject: BUG #7795: Cannot choose UTF-8 encoding for initdb