[HACKERS] postgres_fdw: correct regression test for parameterized scan forforeign table - Mailing list pgsql-hackers

From Etsuro Fujita
Subject [HACKERS] postgres_fdw: correct regression test for parameterized scan forforeign table
Date
Msg-id 93684211-1f78-514f-84a7-c6b434a0921a@lab.ntt.co.jp
Whole thread Raw
List pgsql-hackers
Hi,

While working on adding support for parameterized foreign joins to  
postgres_fdw, I noticed that commit  
e4106b2528727c4b48639c0e12bf2f70a766b910 forgot to modify a test query  
for execution of a parameterized foreign scan for a foreign table:

--- parameterized remote path
+-- parameterized remote path for foreign table
  EXPLAIN (VERBOSE, COSTS false)
-  SELECT * FROM ft2 a, ft2 b WHERE a.c1 = 47 AND b.c1 = a.c2;
+  SELECT * FROM "S 1"."T 1" a, ft2 b WHERE a."C 1" = 47 AND b.c1 = a.c2;
  SELECT * FROM ft2 a, ft2 b WHERE a.c1 = 47 AND b.c1 = a.c2;

The query in the last line as-is would test to see if the remote join  
works correctly, which isn't the right thing to do here.  Attached is a  
small patch for addressing that.

Best regards,
Etsuro Fujita

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Attachment

pgsql-hackers by date:

Previous
From: Thomas Munro
Date:
Subject: [HACKERS] Problem in Parallel Bitmap Heap Scan?
Next
From: Ashutosh Bapat
Date:
Subject: Re: [HACKERS] Partition-wise join for join between (declaratively)partitioned tables