Re: A small bug in gram.y - Mailing list pgsql-hackers

From Gokulakannan Somasundaram
Subject Re: A small bug in gram.y
Date
Msg-id 9362e74e0911022221n11394432v96cd5302adbacbca@mail.gmail.com
Whole thread Raw
In response to A small bug in gram.y  (Gokulakannan Somasundaram <gokul007@gmail.com>)
Responses Re: A small bug in gram.y
List pgsql-hackers
Hmmm.... no-one else feels this as a bug????<br /><br />The logic is that a function call is made for "similar" and the
positionwhere SIMILAR occurs is at the third position, but it has been coded that it is at fifth position.  <br /><br
/>Thanks,<br/>Gokul.<br /><br /><div class="gmail_quote">On Tue, Oct 27, 2009 at 6:51 AM, Gokulakannan Somasundaram
<spandir="ltr"><<a href="mailto:gokul007@gmail.com">gokul007@gmail.com</a>></span> wrote:<br /><blockquote
class="gmail_quote"style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Hi,<br/>   In the gram.y, under a_expr rule<br />   under the subrule "a_expr NOT SIMILAR TO a_expr            %prec
SIMILAR"<br/>   the action is as follows<br />   {<br />                    FuncCall *n = makeNode(FuncCall);<br />    
               n->funcname = SystemFuncName("similar_escape");<br />                    n->args = list_make2($5,
makeNullAConst(-1));<br/>                    n->agg_star = FALSE;<br />                    n->agg_distinct =
FALSE;<br/>                     n->func_variadic = FALSE;<br />                    n->over = NULL;<br />       
           n->location = @5;<br />                    $$ = (Node *) makeSimpleA_Expr(AEXPR_OP, "!~", $1, (Node *) n,
@2);<br/>     }<br /><br />     I think the n->location should be @3. <br /><br />Thanks,<br />Gokul.<br
/></blockquote></div><br/> 

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: per-tablespace random_page_cost/seq_page_cost
Next
From: Heikki Linnakangas
Date:
Subject: Re: A small bug in gram.y