Re: [PATCH] Provide more information to filter_prepare - Mailing list pgsql-hackers

From Markus Wanner
Subject Re: [PATCH] Provide more information to filter_prepare
Date
Msg-id 93326387-bc98-a9e3-f684-a02fef142da7@enterprisedb.com
Whole thread Raw
In response to Re: [PATCH] Provide more information to filter_prepare  (Amit Kapila <amit.kapila16@gmail.com>)
Responses Re: [PATCH] Provide more information to filter_prepare  (vignesh C <vignesh21@gmail.com>)
List pgsql-hackers
On 29.03.21 11:53, Amit Kapila wrote:
> Okay, but just in the previous sentence ("However, reuse of the same
> <parameter>gid</parameter> for example by a downstream node using
> multiple subscriptions may lead to it not being a unique
> identifier."), you have explained how sending a GID identifier can
> lead to a non-unique identifier for multiple subscriptions.

Maybe the example of the downstream node is a bad one.  I understand 
that can cause confusion.  Let's leave away that example and focus on 
the output plugin side.  v6 attached.

> And then
> in the next line, the way you are suggesting to generate GID by use of
> XID seems to have the same problem, so that caused confusion for me.

It was not intended as a suggestion for how to generate GIDs at all. 
Hopefully leaving away that bad example will make it less likely to 
appear related to GID generation on the subscriber.

Regards

Markus

Attachment

pgsql-hackers by date:

Previous
From: "Joel Jacobson"
Date:
Subject: Re: Idea: Avoid JOINs by using path expressions to follow FKs
Next
From: Etsuro Fujita
Date:
Subject: Obsolete comment in postgres_fdw.c