Re: extended stats on partitioned tables - Mailing list pgsql-hackers

From Tomas Vondra
Subject Re: extended stats on partitioned tables
Date
Msg-id 928ad999-6680-bf72-450c-ae96d569f6ba@enterprisedb.com
Whole thread Raw
In response to Re: extended stats on partitioned tables  (Tomas Vondra <tomas.vondra@enterprisedb.com>)
List pgsql-hackers
On 12/13/21 14:48, Justin Pryzby wrote:
> On Sun, Dec 12, 2021 at 10:29:39PM +0100, Tomas Vondra wrote:
>>> In your 0003 patch, the "if inh: break" isn't removed from examine_variable(),
>>> but the corresponding thing is removed everywhere else.
>>
>> Ah, you're right. And it wasn't updated in the 0002 patch either - it
>> should do the relkind check too, to allow partitioned tables. Fixed.
> 
> I think you fixed it in 0002 (thanks) but still wasn't removed from 0003?
> 

D'oh! Those repeated rebase conflicts got me quite confused.

> In these comments:
> +        * When dealing with regular inheritance trees, ignore extended stats
> +        * (which were built without data from child rels, and thus do not
> +        * represent them). For partitioned tables data from partitions are
> +        * in the stats (and there's no data in the non-leaf relations), so
> +        * in this case we do consider extended stats.
> 
> I suggest to add a comment after "For partitioned tables".
> 

I've reworded the comment a bit, hopefully it's a bit clearer now.


regards

-- 
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachment

pgsql-hackers by date:

Previous
From: Huansong Fu
Date:
Subject: Re: bugfix: invalid bit/varbit input causes the log file to be unreadable
Next
From: Andrew Dunstan
Date:
Subject: Re: conchuela has some SSL issues