Re: pgsql: Fix BRIN to use SnapshotAny during summarization - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Fix BRIN to use SnapshotAny during summarization
Date
Msg-id 928.1438900846@sss.pgh.pa.us
Whole thread Raw
In response to pgsql: Fix BRIN to use SnapshotAny during summarization  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
Responses Re: pgsql: Fix BRIN to use SnapshotAny during summarization  (Tom Lane <tgl@sss.pgh.pa.us>)
Using contrib modules in check (Re: pgsql: Fix BRIN to use SnapshotAny during summarization)  (Christoph Berg <myon@debian.org>)
List pgsql-committers
Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> Fix BRIN to use SnapshotAny during summarization

This patch added an isolation test that fails unless contrib/pageinspect
has been built and installed.  I do not find that acceptable.  It causes
"make check-world" to fail ... and no, installing the extension during
make check-world isn't going to make me happier.

I don't really think we need this isolation test at all, but if we do,
please fix it to not rely on any extensions.  Perhaps looking at
pg_relation_size or some such would do?  Or you could just issue
a query that should use the index, and see if it finds the rows it
ought to.

            regards, tom lane


pgsql-committers by date:

Previous
From: Bruce Momjian
Date:
Subject: pgsql: 9.5 release notes: mention change to CRC-32C
Next
From: Tom Lane
Date:
Subject: pgsql: Fix eclass_useful_for_merging to give valid results for appendre