Postgres Pro
Downloads
Home   >   mailing lists

Re: [HACKERS] Page Scan Mode in Hash Index - Mailing list pgsql-hackers

From Jesper Pedersen
Subject Re: [HACKERS] Page Scan Mode in Hash Index
Date
Msg-id 926e3104-8fb0-9d2d-e0b3-c3efd7c8bc3a@redhat.com
Whole thread Raw
In response to Re: [HACKERS] Page Scan Mode in Hash Index  (Ashutosh Sharma <ashu.coek88@gmail.com>)
Responses Re: [HACKERS] Page Scan Mode in Hash Index  (Ashutosh Sharma <ashu.coek88@gmail.com>)
List pgsql-hackers
Tree view 
Hi,

On 03/23/2017 02:11 PM, Ashutosh Sharma wrote:
> On Thu, Mar 23, 2017 at 8:29 PM, Jesper Pedersen
> <jesper.pedersen@redhat.com> wrote:
>> 0001v2:
>>
>> In hashgettuple() you can remove the 'currItem' and 'offnum' from the 'else'
>> part, and do the assignment inside
>>
>>   if (so->numKilled < MaxIndexTuplesPerPage)
>>
>> instead.
>>
>
> Done. Please have a look into the attached v3 patch.
>
>>
>> No new comments for 0002 and 0003.
>
> okay. Thanks.
>

I'll keep the entry in 'Needs Review' if Alexander, or others, want to 
add their feedback.

(Best to post the entire patch series each time)

Best regards, Jesper

pgsql-hackers by date:

Previous
From: Mithun Cy
Date:
Subject: Re: [HACKERS] Patch: Write Amplification Reduction Method (WARM)
Next
From: Andrew Gierth
Date:
Subject: Re: [HACKERS] Hash support for grouping sets