Re: [PATCH] Implement INSERT SET syntax - Mailing list pgsql-hackers

From Gareth Palmer
Subject Re: [PATCH] Implement INSERT SET syntax
Date
Msg-id 9253E61F-A278-40B4-AC24-F571C48F4181@internetnz.net.nz
Whole thread Raw
In response to Re: [PATCH] Implement INSERT SET syntax  (movead li <movead.li@highgo.ca>)
List pgsql-hackers
Hi Movead,

> On 22/04/2020, at 2:40 PM, movead li <movead.li@highgo.ca> wrote:
> 
> The following review has been posted through the commitfest application:
> make installcheck-world:  tested, passed
> Implements feature:       tested, passed
> Spec compliant:           tested, passed
> Documentation:            tested, passed
> 
> It builds failed by applying to the latest code version, and I try head
> '73025140885c889410b9bfc4a30a3866396fc5db' which work well.
> 
> The new status of this patch is: Waiting on Author

Thank you for the review, attached is v7 of the patch which should
apply correcly to HEAD.

This version now uses it's own production rule for the SET clause to
avoid the issue with MultiAssigmentRef nodes in the targetList.


Attachment

pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: 2pc leaks fds
Next
From: Peter Geoghegan
Date:
Subject: Re: xid wraparound danger due to INDEX_CLEANUP false