Re: Re: [COMMITTERS] pgsql: Extend framework from commit 53be0b1ad to report latch waits. - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Re: [COMMITTERS] pgsql: Extend framework from commit 53be0b1ad to report latch waits.
Date
Msg-id 9212.1476463427@sss.pgh.pa.us
Whole thread Raw
In response to Re: Re: [COMMITTERS] pgsql: Extend framework from commit 53be0b1ad to report latch waits.  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: Re: [COMMITTERS] pgsql: Extend framework from commit 53be0b1ad to report latch waits.  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes:
> On Fri, Oct 14, 2016 at 9:10 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Well, if it has no tests *and* it's not getting installed, what's
>> the point of having it at all?

> It's intended as a demonstration of stuff you could do with background
> workers.  Perhaps that begs the question of why Alvaro included it in
> the set of things that got moved from contrib to src/test/modules, but
> I'm still of the opinion that we should build everything in
> src/test/modules when the user does 'make world', whether it has tests
> defined or not.

TBH, I can't muster much sympathy for that position.  Make a test case
for it, and the problem goes away, not to mention that confidence in
whether it actually works (not just compiles) goes up a lot.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: PL/Python adding support for multi-dimensional arrays
Next
From: Christoph Berg
Date:
Subject: Re: Patch to implement pg_current_logfile() function