Re: libpq: Fix wrong connection status on invalid "connect_timeout" - Mailing list pgsql-hackers

From Lars Kanis
Subject Re: libpq: Fix wrong connection status on invalid "connect_timeout"
Date
Msg-id 91445b6f-85c9-acaa-a268-d7d6bfd43d87@greiz-reinsdorf.de
Whole thread Raw
In response to Re: libpq: Fix wrong connection status on invalid "connect_timeout"  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
Am 18.10.19 um 05:06 schrieb Michael Paquier:

> So attached is a patch to skip trailing whitespaces as well,
> which also fixes the issue with ECPG.  I have refactored the parsing
> logic a bit while on it.  The comment at the top of parse_int_param()
> needs to be reworked a bit more.

I tested this and it looks good to me. Maybe you could omit some
redundant 'end' checks, as in the attached patch. Or was your intention
to verify non-NULL 'end'?


> Perhaps we could add directly regression
> tests for libpq.  I'll start a new thread about that once we are done
> here, the topic is larger.

We have around 650 tests on ruby-pg to ensure everything runs as
expected and I always wondered how the API of libpq is being verified.


--
Kind Regards,
Lars Kanis


Attachment

pgsql-hackers by date:

Previous
From: Corey Huinker
Date:
Subject: Add Change Badges to documentation
Next
From: Amit Kapila
Date:
Subject: Re: PATCH: logical_work_mem and logical streaming of largein-progress transactions