Re: further #include cleanup (IWYU) - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: further #include cleanup (IWYU)
Date
Msg-id 91058951-b86f-4647-a488-d7812a3bb0b7@eisentraut.org
Whole thread Raw
In response to Re: further #include cleanup (IWYU)  (Matthias van de Meent <boekewurm+postgres@gmail.com>)
List pgsql-hackers
On 27.01.25 15:10, Matthias van de Meent wrote:
> On Wed, 6 Nov 2024 at 11:50, Peter Eisentraut <peter@eisentraut.org> wrote:
>>
>> Seeing no further comments (or any easy alternatives), I have committed
>> this last patch as is.
> 
> I just noticed that the #define for MaxArraySize in utils/array.h uses
> MaxAllocSize without including the utils/memutils.h header. Is that on
> purpose and is the user expected to include both headers, or should
> utils/memutils.h be included in utils/array.h?

I have found a number of cases like this, where a macro definition in a 
header uses a symbol that is defined in another header that is not 
included.  This is not something that the IWYU tool set can track.

In general, this kind of thing is probably best avoided, but it would 
probably require individual investigation of each case.



pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Improve error handling for invalid slots and ensure a same 'inactive_since' time for inactive slots
Next
From: "Vitaly Davydov"
Date:
Subject: Re: An improvement of ProcessTwoPhaseBuffer logic