createdb compares strategy as case-sensitive - Mailing list pgsql-hackers

From Tomas Vondra
Subject createdb compares strategy as case-sensitive
Date
Msg-id 90c6913a-1dd2-42b4-8365-ce3b09c39b17@enterprisedb.com
Whole thread Raw
Responses Re: createdb compares strategy as case-sensitive
List pgsql-hackers
Hi,

While doing some testing with createdb, I noticed it only accepts
file_copy/wal_log as valid strategies, not FILE_COPY/WAL_LOG (which is
what the docs say). The same thing applies to CREATE DATABASE.

The problem is that createdb() does the check using strcmp() which is
case-sensitive. IMHO this should do pg_strcasecmp() which is what we do
for other string parameters nearby.

Patch attached. This should be backpatched to 15, I think.


regards

-- 
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Performance of JSON_TABLE vs jsonb_to_recordset
Next
From: Tom Lane
Date:
Subject: Re: createdb compares strategy as case-sensitive