Re: trace_recovery_messages - Mailing list pgsql-hackers

From Tom Lane
Subject Re: trace_recovery_messages
Date
Msg-id 9048.1282159382@sss.pgh.pa.us
Whole thread Raw
In response to trace_recovery_messages  (Fujii Masao <masao.fujii@gmail.com>)
List pgsql-hackers
Fujii Masao <masao.fujii@gmail.com> writes:
> The explanation of trace_recovery_messages in the document
> is inconsistent with the definition of it in guc.c.

Setting the default to WARNING is confusing and useless, because
there are no trace_recovery calls with that debug level.  IMO the
default setting should be LOG, which makes trace_recovery() a clear
no-op (rather than not clearly a no-op).  There is circumstantial
evidence in the code that this was the original intention:

int            trace_recovery_messages = LOG;

The documentation of the parameter is about as clear as mud, too.
We need to explain what it does rather than just copy-and-paste
a lot of text from log_min_messages.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Return of the Solaris vacuum polling problem -- anyone remember this?
Next
From: "Kevin Grittner"
Date:
Subject: Re: Return of the Solaris vacuum polling problem -- anyone remember this?