Re: Converting tab-complete.c's else-if chain to a switch - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: Converting tab-complete.c's else-if chain to a switch
Date
Msg-id 901EFF66-B387-4E69-BC63-C6A0512C2AF1@yesql.se
Whole thread Raw
In response to Converting tab-complete.c's else-if chain to a switch  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
> On 10 Oct 2024, at 09:22, Anthonin Bonnefoy <anthonin.bonnefoy@datadoghq.com> wrote:

> psql tries to read the previous word when matches are NULL. However,
> there's no previous word set here, leading to the segfault.
>
> I've attached a patch that checks if the previous word does exist
> before trying to use it, along with an additional test for this
> codepath.

Nice, I was just typing up an email with the same fix when your landed in my
inbox after having ended up with a segfaulting psql testing a patch.  (I didn't
include a test though so yours is better.) From reading the code I agree that
we must check previous_words_count here so +1 on this patch.

--
Daniel Gustafsson




pgsql-hackers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: Re: Doc: typo in config.sgml
Next
From: Daniel Gustafsson
Date:
Subject: Re: Allow default \watch interval in psql to be configured