Getting rid of OverrideSearhPath in namespace.c - Mailing list pgsql-hackers

From Alexander Lakhin
Subject Getting rid of OverrideSearhPath in namespace.c
Date
Msg-id 8ffb4650-52c4-6a81-38fc-8f99be981130@gmail.com
Whole thread Raw
Responses Re: Getting rid of OverrideSearhPath in namespace.c
List pgsql-hackers
Hello hackers,

As a follow-up for the CVE-2023-2454 fix, I think that it makes sense to
completely remove unsafe functions
PushOverrideSearchPath()/PopOverrideSearchPath(), which are not used in the
core now.
Please look at the patch attached.

Beside that, maybe it's worth to rename three functions in "Override" in
their names: GetOverrideSearchPath(), CopyOverrideSearchPath(),
OverrideSearchPathMatchesCurrent(), and then maybe struct OverrideSearchPath.
Noah Misch proposed name GetSearchPathMatcher() for the former.

What do you think?

Best regards,
Alexander
Attachment

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Improve heapgetpage() performance, overhead from serializable
Next
From: Magnus Hagander
Date:
Subject: Re: Should we remove db_user_namespace?