(Comment)Bug in CteScanNext - Mailing list pgsql-hackers

From Jim Nasby
Subject (Comment)Bug in CteScanNext
Date
Msg-id 8fa74614-5ed8-000e-2204-184931cc28a1@BlueTreble.com
Whole thread Raw
Responses Re: (Comment)Bug in CteScanNext  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
In CteScanNext():
/*      * If we are not at the end of the tuplestore, or are going 
backwards, try      * to fetch a tuple from tuplestore.      */     eof_tuplestore =
tuplestore_ateof(tuplestorestate);
     if (!forward && eof_tuplestore)

For the comment to be correct, wouldn't the condition need to be 
(!forward || !eof_tuplestore)?
-- 
Jim Nasby, Data Architect, Blue Treble Consulting, Austin TX
Experts in Analytics, Data Architecture and PostgreSQL
Data in Trouble? Get it in Treble! http://BlueTreble.com
855-TREBLE2 (855-873-2532)   mobile: 512-569-9461



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Password identifiers, protocol aging and SCRAM protocol
Next
From: Jim Nasby
Date:
Subject: Re: Renaming of pg_xlog and pg_clog