[PATCH] Present all committed transaction to the output plugin - Mailing list pgsql-hackers

From Markus Wanner
Subject [PATCH] Present all committed transaction to the output plugin
Date
Msg-id 8daecb44-c214-765d-5a67-3539bd153367@enterprisedb.com
Whole thread Raw
List pgsql-hackers
Hi,

attached is a patch that I think is cleaning up the API between Postgres 
and the logical decoding plugin.  Up until now, not only transactions 
rolled back, but also some committed transactions were filtered and not 
presented to the output plugin.  While it is documented that aborted 
transactions are not decoded, the second exception has not been documented.

The difference is with committed empty transactions that have a snapshot 
versus those that do not.  I think that's arbitrary and propose to 
remove this distinction, so that all committed transactions are decoded.

In the case of decoding a two-phase transaction, I argue that this is 
even more important, as the gid potentially carries information.

Please consider the attached patch, which drops the mentioned filter. 
It also adjusts tests to show the difference and provides a minor 
clarification to the documentation.

Regards

Markus

Attachment

pgsql-hackers by date:

Previous
From: Damir Simunic
Date:
Subject: Re: Extensibility of the PostgreSQL wire protocol
Next
From: "Joel Jacobson"
Date:
Subject: Re: Some regular-expression performance hacking