Re: ​function arguments are not PG_FUNCTION_ARGS, how to pass Node *escontext - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: ​function arguments are not PG_FUNCTION_ARGS, how to pass Node *escontext
Date
Msg-id 8da2bcd5-323e-ad93-1250-030c383abed7@dunslane.net
Whole thread Raw
In response to ​function arguments are not PG_FUNCTION_ARGS, how to pass Node *escontext  (jian he <jian.universality@gmail.com>)
Responses Re: ​function arguments are not PG_FUNCTION_ARGS, how to pass Node *escontext
List pgsql-hackers


On 2023-06-26 Mo 07:20, jian he wrote:
static
Datum return_numeric_datum(char *token)
{    Datum   numd;    Node    *escontext;
    if (!DirectInputFunctionCallSafe(numeric_in, token,                                    InvalidOid, -1,                                    escontext,                                    &numd));        elog(INFO,"something is wrong");    return numd;
}


To start with, the semicolon at the end of that if appears bogus. The elog is indented to look like it's conditioned by the if but the semicolon makes it not be.

There are compiler switches in modern gcc at least that help you detect things like this.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

pgsql-hackers by date:

Previous
From: jian he
Date:
Subject: ​function arguments are not PG_FUNCTION_ARGS, how to pass Node *escontext
Next
From: Ashutosh Bapat
Date:
Subject: Re: logical decoding and replication of sequences, take 2