Re: PATCH: Exclude additional directories in pg_basebackup - Mailing list pgsql-hackers

From David Steele
Subject Re: PATCH: Exclude additional directories in pg_basebackup
Date
Msg-id 8d768ced-7f16-b690-ec13-f42d47432ada@pgmasters.net
Whole thread Raw
In response to Re: PATCH: Exclude additional directories in pg_basebackup  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
On 8/17/16 7:56 PM, Michael Paquier wrote:
> On Thu, Aug 18, 2016 at 1:35 AM, Alvaro Herrera
> <alvherre@2ndquadrant.com> wrote:
>> I don't remember how pg_snapshot works, but it's probably fine
>> to start with an empty subdir (is it possible to export a snapshot from
>> a prepared transaction?)
> 
> From xact.c:
>     /*
>      * Likewise, don't allow PREPARE after pg_export_snapshot.  This could be
>      * supported if we added cleanup logic to twophase.c, but for now it
>      * doesn't seem worth the trouble.
>      */
>     if (XactHasExportedSnapshots())
>         ereport(ERROR,
>                 (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
>         errmsg("cannot PREPARE a transaction that has exported snapshots")));
> So that's fine.

Thank you for tracking that down, Michael.

-- 
-David
david@pgmasters.net



pgsql-hackers by date:

Previous
From: Magnus Hagander
Date:
Subject: Re: Anyone want to update our Windows timezone map?
Next
From: Tom Lane
Date:
Subject: Re: Anyone want to update our Windows timezone map?