Re: Newline after --progress report - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: Newline after --progress report
Date
Msg-id 8b57b3e4-f7a6-8acd-5a79-9129ccae6782@iki.fi
Whole thread Raw
In response to Re: Newline after --progress report  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 17/08/2020 16:59, Tom Lane wrote:
> Heikki Linnakangas <hlinnaka@iki.fi> writes:
>> Good point. Pushed a patch along those lines.
> 
> Uh ... you patched v12 but not v13?

Darn, I forgot it exists.

> Also, I'd recommend that you NOT do this:
> 
> +   fprintf(stderr, (!finished && isatty(fileno(stderr))) ? "\r" : "\n");
> 
> as it breaks printf format verification in many/most compilers.

Ok. I pushed the same commit to v12 as to other branches now, to keep 
them in sync. I'll go fix that as a separate commit. Thanks!

- Heikki



pgsql-hackers by date:

Previous
From: Dilip Kumar
Date:
Subject: Re: Parallel bitmap index scan
Next
From: Tom Lane
Date:
Subject: Re: One-off failure in "cluster" test