Re: plpgsql memory leak in 7.3.2? (repost) - Mailing list pgsql-general

From Mark Cave-Ayland
Subject Re: plpgsql memory leak in 7.3.2? (repost)
Date
Msg-id 8F4A22E017460A458DB7BBAB65CA6AE502643E@webbased9.wb9.webbased.co.uk
Whole thread Raw
In response to plpgsql memory leak in 7.3.2? (repost)  ("Mark Cave-Ayland" <m.cave-ayland@webbased.co.uk>)
List pgsql-general
> > Whilst continuing work on some of our large tables again, we've
> > encountered what we think may be a memory leak in plpgsql in 7.3.2.
>
> Yup, you're right.  Looks like I introduced several memory
> leaks in plpgsql when I modified spi.c to return a tuple
> descriptor even with zero tuples returned: some plpgsql
> routines assumed they didn't need to do SPI_freetuptable()
> after retrieving no tuples.  Patch attached, or you can grab
> the updated pl_exec.c from our CVS server.
>
>             regards, tom lane

Hi Tom,

Firstly I'd just like to say I am really impressed by the phenomenal
response time from posting the email to receiving a patch - absolutely
fantastic, especially on a Sunday! I've built up a new RPM to test the
patch and the test case from the email works brilliantly now. We'll
probably start tagging more data from large tables on our live system
over next weekend which will give me a chance to give it a through
testing, but as the email test case works I'm really confident that
you've managed to nail this one!


Once again, thank you very much,

Mark.


---

Mark Cave-Ayland
Webbased Ltd.
Tamar Science Park
Derriford
Plymouth
PL6 8BX
England

Tel: +44 (0)1752 764445
Fax: +44 (0)1752 764446


This email and any attachments are confidential to the intended
recipient and may also be privileged. If you are not the intended
recipient please delete it from your system and notify the sender. You
should not copy it or use it for any purpose nor disclose or distribute
its contents to any other person.



pgsql-general by date:

Previous
From: Adam Witney
Date:
Subject: [OT] Re: problem while inslalling fink on ms os x
Next
From: "Munteanu Gabriel"
Date:
Subject: wal-debug