Re: inefficient loop in StandbyReleaseLockList() - Mailing list pgsql-hackers

From Bossart, Nathan
Subject Re: inefficient loop in StandbyReleaseLockList()
Date
Msg-id 8D394A05-1B89-42DD-96F3-BCF41016EEC7@amazon.com
Whole thread Raw
In response to Re: inefficient loop in StandbyReleaseLockList()  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 10/31/21, 12:39 PM, "Tom Lane" <tgl@sss.pgh.pa.us> wrote:
> Yeah, there's no expectation that this data structure needs to be kept
> consistent after an error; and I'm not real sure that the existing
> code could claim to satisfy such a requirement if we did need it.
> (There's at least a short window where the caller's hash table entry
> will point at an already-freed List.)

Right.

> Pushed the patch as given.  I've not yet reviewed other list_delete_first
> callers, but I'll take a look.  (I seem to remember that I did survey
> them while writing 1cff1b95a, but I evidently missed that this code
> could be dealing with a list long enough to be problematic.)

Thanks!

Nathan


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: inefficient loop in StandbyReleaseLockList()
Next
From: Daniel Gustafsson
Date:
Subject: Re: Fix C4819 warning in MSVC