Re: Remove a unused argument from qual_is_pushdown_safe - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: Remove a unused argument from qual_is_pushdown_safe
Date
Msg-id 8CA0AAC5-688F-4189-BDA0-B684BBDC29BA@yesql.se
Whole thread Raw
In response to Re: Remove a unused argument from qual_is_pushdown_safe  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
> On 28 Nov 2022, at 15:15, Tom Lane <tgl@sss.pgh.pa.us> wrote:

> My viewpoint is that this change is misguided.  Even if the current
> coding of qual_is_pushdown_safe doesn't happen to reference the
> subquery, it might need to in future.

If I understand the code correctly the variable has some value in terms of
"documenting the code" (for lack of better terminology), and I would assume
virtually every modern compiler to figure out it's not needed.

--
Daniel Gustafsson        https://vmware.com/




pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Remove a unused argument from qual_is_pushdown_safe
Next
From: Simon Riggs
Date:
Subject: Bug in wait time when waiting on nested subtransaction