> On Jun 17, 2026, at 09:17, Tatsuo Ishii <ishii@postgresql.org> wrote:
>
>>>> To fix this, ParseFuncOrColumn() now checks whether other than window
>>>> functions are used with the null treatment clause. If so, error out.
>>>>
>>>> Also remove the unnecessary test for "aggregate functions do not
>>>> accept RESPECT/IGNORE NULLS" because it is now checked in the
>>>> early-stage new check. The window regression test expected file is
>>>> changed accordingly.
>>>
>>> I'm going to push the patch today if there's no objection.
>>
>> The code looks good to me, and the commit message is clear and well-written.
>
> Thank you for the review!
> I have pushed the patch to master branch.
> https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=4e5920e6de87dc1ed761d2a898b7786c50c11db2
> --
> Tatsuo Ishii
> SRA OSS K.K.
> English: http://www.sraoss.co.jp/index_en/
> Japanese:http://www.sraoss.co.jp
>
Hi Tatsuo-san,
Sorry for jumping in. I didn’t review the patch, but while browsing recent commits, I noticed that this commit has a
smallissue: the errmsg should start with a lowercase character, according to the error style guide [1]:
```
Primary error messages: Do not capitalize the first letter. Do not end a message with a period. Do not even think about
endinga message with an exclamation point.
```
The attached diff is a quick fix that changes “Only” to “only” and updates the expected output accordingly.
[1] https://www.postgresql.org/docs/current/error-style-guide.html
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
