Re: IGNORE/RESPECT NULLS can be specified for (prokind == 'f'). - Mailing list pgsql-hackers

From Tatsuo Ishii
Subject Re: IGNORE/RESPECT NULLS can be specified for (prokind == 'f').
Date
Msg-id 20260617.125805.1854568406469657411.ishii@postgresql.org
Whole thread
In response to Re: IGNORE/RESPECT NULLS can be specified for (prokind == 'f').  (Chao Li <li.evan.chao@gmail.com>)
Responses Re: IGNORE/RESPECT NULLS can be specified for (prokind == 'f').
List pgsql-hackers
Hi Chao,

> Hi Tatsuo-san,
> 
> Sorry for jumping in. I didn’t review the patch, but while browsing recent commits, I noticed that this commit has a
smallissue: the errmsg should start with a lowercase character, according to the error style guide [1]:
 
> ```
> Primary error messages: Do not capitalize the first letter. Do not end a message with a period. Do not even think
aboutending a message with an exclamation point.
 
> ```
> 
> The attached diff is a quick fix that changes “Only” to “only” and updates the expected output accordingly.
> 
> [1] https://www.postgresql.org/docs/current/error-style-guide.html

You are right. I don't know why I forgot the rule. Patch pushed.
Thank you!
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp




pgsql-hackers by date:

Previous
From: Peter Smith
Date:
Subject: Re: Support EXCEPT for TABLES IN SCHEMA publications
Next
From: David Rowley
Date:
Subject: Re: Fix tuple deformation with virtual generated NOT NULL columns