Re: IGNORE/RESPECT NULLS can be specified for (prokind == 'f'). - Mailing list pgsql-hackers

From Tatsuo Ishii
Subject Re: IGNORE/RESPECT NULLS can be specified for (prokind == 'f').
Date
Msg-id 20260617.101714.902726172425852267.ishii@postgresql.org
Whole thread
Responses Re: IGNORE/RESPECT NULLS can be specified for (prokind == 'f').
List pgsql-hackers
>> > To fix this, ParseFuncOrColumn() now checks whether other than window
>> > functions are used with the null treatment clause. If so, error out.
>> >
>> > Also remove the unnecessary test for "aggregate functions do not
>> > accept RESPECT/IGNORE NULLS" because it is now checked in the
>> > early-stage new check. The window regression test expected file is
>> > changed accordingly.
>>
>> I'm going to push the patch today if there's no objection.
> 
> The code looks good to me, and the commit message is clear and well-written.

Thank you for the review!
I have pushed the patch to master branch.
https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=4e5920e6de87dc1ed761d2a898b7786c50c11db2
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp



pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: First draft of PG 19 release notes
Next
From: Masahiko Sawada
Date:
Subject: Re: Fix race condition in pg_get_publication_tables with concurrent DROP TABLE