Call perror on popen failure - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Call perror on popen failure
Date
Msg-id 89B00F63-40F7-4D82-8353-DC9CABBAC1D1@yesql.se
Whole thread Raw
Responses Re: Call perror on popen failure
Re: Call perror on popen failure
List pgsql-hackers
If popen fails in pipe_read_line we invoke perror for the error message, and
pipe_read_line is in turn called by find_other_exec which is used in both
frontend and backend code.  This is an old codepath, and it seems like it ought
to be replaced with the more common logging tools we now have like in the
attached diff (which also makes the error translated as opposed to now).  Any
objections to removing this last perror() call?

--
Daniel Gustafsson


Attachment

pgsql-hackers by date:

Previous
From: "Andrey M. Borodin"
Date:
Subject: Re: speed up a logical replica setup
Next
From: Bharath Rupireddy
Date:
Subject: Re: Add new error_action COPY ON_ERROR "log"