Re: BUG #5705: btree_gist: Index on inet changes query result - Mailing list pgsql-bugs

From Tom Lane
Subject Re: BUG #5705: btree_gist: Index on inet changes query result
Date
Msg-id 8973.1286841006@sss.pgh.pa.us
Whole thread Raw
In response to BUG #5705: btree_gist: Index on inet changes query result  ("Andreas Karlsson" <andreas@proxel.se>)
Responses Re: BUG #5705: btree_gist: Index on inet changes query result  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-bugs
"Andreas Karlsson" <andreas@proxel.se> writes:
> I was looking at the code to see how one would improve indexing of the inet
> types and saw an inconsistency between the compressed format
> (gbt_inet_compress) and how network_cmp_internal works. The btree_gist
> module ignores the netmask.

Well, actually the btree_gist implementation for inet is a completely
broken piece of junk: it thinks that convert_network_to_scalar is 100%
trustworthy and can be used as a substitute for the real comparison
functions, which isn't even approximately true.  I'm not sure why
Teodor implemented it like that instead of using the type's real
comparison functions, but it's pretty much useless if you want the
same sort order that the type itself defines.

            regards, tom lane

pgsql-bugs by date:

Previous
From: Chris English
Date:
Subject: Re: pg_dumpall -> by hand without --binary-upgrade or BUG #5690: pg_upgrade fails
Next
From: Robert Haas
Date:
Subject: Re: pg_dumpall -> by hand without --binary-upgrade or BUG #5690: pg_upgrade fails