Re: Trivial libpq refactoring patch (was: Re: Another review of URI for libpq, v7 submission) - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Trivial libpq refactoring patch (was: Re: Another review of URI for libpq, v7 submission)
Date
Msg-id 8963.1332432615@sss.pgh.pa.us
Whole thread Raw
In response to Trivial libpq refactoring patch (was: Re: Another review of URI for libpq, v7 submission)  (Alex Shulgin <ash@commandprompt.com>)
List pgsql-hackers
Alex Shulgin <ash@commandprompt.com> writes:
> While working on this fix I've figured out that I need my
> conninfo_uri_parse to support use_defaults parameter, like
> conninfo(_array)_parse functions do.

> The problem is that the block of code which does the defaults handling
> is duplicated in both of the above functions.  What I'd like to do is
> extract it into a separate function to call.  What I wouldn't like is
> bloating the original URI patch with this unrelated change.

Applied with minor adjustments --- notably, I thought
conninfo_add_defaults was a better name for the function.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: HOT updates & REDIRECT line pointers
Next
From: "Kevin Grittner"
Date:
Subject: Re: Gsoc2012 Idea --- Social Network database schema