Re: Compile Failue on win32 - pipe.c using ereport - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Compile Failue on win32 - pipe.c using ereport
Date
Msg-id 8959.1088607877@sss.pgh.pa.us
Whole thread Raw
In response to Re: Compile Failue on win32 - pipe.c using ereport  ("Merlin Moncure" <merlin.moncure@rcsonline.com>)
List pgsql-hackers
"Merlin Moncure" <merlin.moncure@rcsonline.com> writes:
>> For the past few days I have experienced compile failure with CVS HEAD
>> on win32.
>> The culprit is src/port/pipe.c which uses ereport() when it only
>> #includes "c.h".

> Try replacing "c.h" with "postgres.h".  I fixed that on the win32
> binaries and forgot to mention it.

There was a recently submitted patch to change postgres.h to c.h in a
bunch of src/port modules, which I applied without looking closely.
Apparently it was a tad overenthusiastic.

The big question here is whether pipe.c is interesting for use in
frontend programs.  If so, it can't use ereport/elog at all, and we'll
need to change the code.  If not, we can just revert the inclusion
mistake.

Are there failures in any other src/port modules now?

            regards, tom lane

pgsql-hackers by date:

Previous
From: "Merlin Moncure"
Date:
Subject: Re: Win32 version question
Next
From: Alvaro Herrera
Date:
Subject: Re: Win32 version question